Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alacritty: broken darwin build #49693

Closed
periklis opened this issue Nov 3, 2018 · 8 comments
Closed

alacritty: broken darwin build #49693

periklis opened this issue Nov 3, 2018 · 8 comments

Comments

@periklis
Copy link
Contributor

periklis commented Nov 3, 2018

Issue description

builder for '/nix/store/ajwnb79524qjli5wflfdhvxya2a9p13p-alacritty-unstable-0.2.1.drv' failed with exit code 101; last 10 log lines:
  thread 'src/meter.rs - meter (line 21)' panicked at 'couldn't compile the test', librustdoc/test.rs:332:13
  note: Run with `RUST_BACKTRACE=1` for a backtrace.


  failures:
      src/meter.rs - meter (line 21)

  test result: FAILED. 0 passed; 1 failed; 3 ignored; 0 measured; 0 filtered out

  error: test failed, to rerun pass '--doc'
[0 built (1 failed)]
error: build of '/nix/store/ajwnb79524qjli5wflfdhvxya2a9p13p-alacritty-unstable-0.2.1.drv' failed

Steps to reproduce

nix build alacritty

Technical details

Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

 - system: `"x86_64-darwin"`
 - host os: `Darwin 18.0.0, macOS 10.14`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.1.3`
 - channels(root): `"nixpkgs-18.09pre149107.3878342ef02"`
 - nixpkgs: `/Users/username/nixpkgs`

cc @Mic92

@Mic92
Copy link
Member

Mic92 commented Nov 3, 2018

Can you try to adapt for alacritty: https://github.com/NixOS/nixpkgs/pull/49661/files ? This might be the same regression here

@periklis
Copy link
Contributor Author

periklis commented Nov 3, 2018

i had hope that the regression is related to the the rust upgrade.

@Mic92
Copy link
Member

Mic92 commented Nov 3, 2018

mhm. I hope this is not due linking llvm against the system version: https://hydra.nixos.org/build/83279533/nixlog/1 No, we are still using a bundled version as the pr is still open: #49557

@Mic92
Copy link
Member

Mic92 commented Nov 3, 2018

@jwilm Have this llvm linking been reported before on macOS? https://hydra.nixos.org/build/83279533/nixlog/1

@danieldk
Copy link
Contributor

danieldk commented Nov 6, 2018

I don't think disabling tests is the solution. I get these linking problems when running tests of work-related Rust projects as well. This seems to have surfaced since the upgrade to Rust 1.30. Interestingly enough I get the same errors with Rust from Mozilla's nix overlay. But I can't find anything in the Rust bug tracker.

@danieldk
Copy link
Contributor

danieldk commented Nov 6, 2018

Another interesting data point. Both in the trace above and in some work project that I tried, the linking error seems to occur in doc tests.

Maybe a temporary work around is not running doc tests for Rust derivations? (cargo test --lib)

@Mic92
Copy link
Member

Mic92 commented Nov 6, 2018

We could disable them globally instead of fixing each package.

danieldk added a commit to danieldk/nixpkgs that referenced this issue Nov 6, 2018
Since Rust 1.30 (?) some Rust crates do not build, see e.g. NixOS#49693 and NixOS#49708
and fail with:

dyld: Symbol not found: __ZTIN4llvm2cl18GenericOptionValueE

So far, the common pattern seems to be that the linking fails in doctests. This
change is a temporary workaround that disables doctests for Rust crates on
Darwin. This avoids the need to patch individual derivations and still runs
library tests.
@periklis
Copy link
Contributor Author

@Mic92 can we close this since rust doctests and jemalloc fixes went in staging?

@Mic92 Mic92 closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants