-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alacritty: broken darwin build #49693
Comments
Can you try to adapt for alacritty: https://github.com/NixOS/nixpkgs/pull/49661/files ? This might be the same regression here |
i had hope that the regression is related to the the rust upgrade. |
mhm. I hope this is not due linking llvm against the system version: https://hydra.nixos.org/build/83279533/nixlog/1 No, we are still using a bundled version as the pr is still open: #49557 |
@jwilm Have this llvm linking been reported before on macOS? https://hydra.nixos.org/build/83279533/nixlog/1 |
I don't think disabling tests is the solution. I get these linking problems when running tests of work-related Rust projects as well. This seems to have surfaced since the upgrade to Rust 1.30. Interestingly enough I get the same errors with Rust from Mozilla's nix overlay. But I can't find anything in the Rust bug tracker. |
Another interesting data point. Both in the trace above and in some work project that I tried, the linking error seems to occur in doc tests. Maybe a temporary work around is not running doc tests for Rust derivations? ( |
We could disable them globally instead of fixing each package. |
Since Rust 1.30 (?) some Rust crates do not build, see e.g. NixOS#49693 and NixOS#49708 and fail with: dyld: Symbol not found: __ZTIN4llvm2cl18GenericOptionValueE So far, the common pattern seems to be that the linking fails in doctests. This change is a temporary workaround that disables doctests for Rust crates on Darwin. This avoids the need to patch individual derivations and still runs library tests.
@Mic92 can we close this since rust doctests and jemalloc fixes went in staging? |
Issue description
Steps to reproduce
nix build alacritty
Technical details
Please run
nix-shell -p nix-info --run "nix-info -m"
and paste theresults.
cc @Mic92
The text was updated successfully, but these errors were encountered: