-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build 32-bit json-glib on machine with large XFS filesystem #68241
Comments
Does the fix suggested in the issue work? Something like the following: --- a/pkgs/development/tools/build-managers/ninja/default.nix
+++ b/pkgs/development/tools/build-managers/ninja/default.nix
@@ -49,6 +49,13 @@
setupHook = ./setup-hook.sh;
+ # fix builds on x86_32 with LFS
+ # https://github.com/NixOS/nixpkgs/issues/68241
+ NIX_CFLAGS_COMPILE = optionals (stdenv.hostPlatform.system == "i686-linux") [
+ "-D_LARGEFILE_SOURCE"
+ "-D_FILE_OFFSET_BITS=64"
+ ];
+
meta = {
description = "Small build system with a focus on speed";
longDescription = '' |
I tried both glensc/ninja-build@038593e and your fix, and they both somehow break ninja:
|
Thank you for your contributions.
|
Any updates on fixing this? |
I marked this as stale due to inactivity. → More info |
I've recently started running into this issue with a bunch of builds, e.h. systemd and gtk3 and @jtojnar's patch seems to fix it. I'll open a PR with it in the next days, if nobody here has any problem with that or wants to do that themselves. |
Nevermind. With this,
|
Turns out cmake sets that as well (but with a more precise match than matching i686-linux): nixpkgs/pkgs/development/tools/build-managers/cmake/default.nix Lines 114 to 118 in b34a4df
|
I seem to be running into the same issue while installing Steam via
Running a 2TiB XFS setup here. Looks like this might have finally been addressed ninja-build/ninja#2203 which has been merged, but isn't yet part of a released version. |
Fixes #68241 > Value too large for defined data type https://hydra.nixos.org/build/213266252 (cherry picked from commit 9434136)
Many various builds are really affected by this, I'm afraid. I'm not putting significant effort into fixing them. |
Describe the bug
On a build machine with a 4TB XFS filesystem, I am unable to build steam and appimage-run because the x86_32 build of json-glib fails:
I believe this is because of a ninja problem related to 64-bit inodes: ninja-build/ninja#829
On another machine with a 1TB XFS filesystem, the build succeeds.
To Reproduce
Steps to reproduce the behavior:
Metadata
"x86_64-linux"
Linux 4.19.65-hardened, NixOS, 19.09.git.4816fb0 (Loris)
yes
yes
nix-env (Nix) 2.3
Maintainer information:
The text was updated successfully, but these errors were encountered: