-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doc: add md-to-db.sh, convert some sections to CommonMark, add 21.11 release notes stub #107444
Conversation
I don't think this should be merged as-is until we have tooling to ensure programmatically (enforced Github Actions maybe?) there's no different versions of the two different versions. Alternatively, if most of the migration is done by a script anyways, we could also have a long-living PR migrating ALL documentation at once, rebased every once and then, and on merge removing the docbook files it converted from. |
e4228b4
to
ae63a51
Compare
8e41a1d
to
71aa11a
Compare
5db076b
to
483e723
Compare
I've added a GitHub Action to this PR to enforce consistency in the generated Markdown files. For reference: |
@jonringer and I talked and he 21.11 release notes to be in Markdown, so I think after the 21.05 branch off we should merge this and create those release notes in Markdown. I can try to update this so it adds the release note stub file too. |
Also updates it to mention running md-to-db.sh.
I've updated this to convert the "contributing to this manual" section (mentioning the need to run the |
thanks for the release stub. Changes look great :) |
The time has come! |
name: NixOS manual checks | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an FYI as actions have changed since the PR was opened: this won't run automatically for first time contributors so it's possible that the docs could drift out of sync.
https://github.blog/2021-04-22-github-actions-update-helping-maintainers-combat-bad-actors/
Would need to do the same as we did in 5ba2e4e (pull_request_target
, permissions:
, and the PR merge ref) to make it run unconditionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, great point.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
RFC 72
See the added README and comments in md-to-db.sh for motivation too.