Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/gnome3: don't install epiphany default" #108107

Merged
merged 3 commits into from
Jan 9, 2021
Merged

Revert "nixos/gnome3: don't install epiphany default" #108107

merged 3 commits into from
Jan 9, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 1, 2021

Motivation for this change

This reverts commit 13b1927, since #98819 is now fixed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 1, 2021
@talyz talyz requested a review from a team January 1, 2021 09:29
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 1, 2021
This was referenced Jan 1, 2021
Merged
Merged
@talyz talyz force-pushed the reintroduce-epiphany branch from 8c4383b to 8ed9987 Compare January 5, 2021 15:29
@worldofpeace
Copy link
Contributor

@ofborg test gnome3

@talyz
Copy link
Contributor Author

talyz commented Jan 9, 2021

@worldofpeace Anything left to address here or can we merge? :)

@worldofpeace worldofpeace merged commit 7c34e83 into NixOS:master Jan 9, 2021
@talyz talyz deleted the reintroduce-epiphany branch January 11, 2021 21:36
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@bbjubjub2494 bbjubjub2494 bbjubjub2494 left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talyz @worldofpeace @bbjubjub2494 @erictapen