Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake/setup-hook.sh: Don't skip build-RPATH #108496

Merged
merged 3 commits into from
Jul 11, 2022
Merged

cmake/setup-hook.sh: Don't skip build-RPATH #108496

merged 3 commits into from
Jul 11, 2022

Commits on Jul 3, 2022

  1. cmake/setup-hook.sh: Don't skip build-RPATH 

    This should simplify using `nix-shell -A` or `nix develop` to develop
CMake based projects. CMake features a mechanism to use a different
RPATH for all executables in the build directory and only rewrite these
RPATHs on installation. This makes it possible to run executables
already from the build directory without having to set LD_LIBRARY_PATH.
This should simplify the checkPhase for cmake based projects and
hopefully not break anything.

Fixes: NixOS#22060
    @knedlsepp @Artturin
    knedlsepp authored and Artturin committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    f7414e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. treewide: Stop setting CMAKE_SKIP_BUILD_RPATH=OFF 

    This is now the new default and thus doesn't need to be set manually
anymore.
    @knedlsepp @Artturin
    knedlsepp authored and Artturin committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1ca04aa View commit details
    Browse the repository at this point in the history

  2. treewide: Remove now-unneeded LD_LIBRARY_PATH in cmake derivations 

    Since the setting DCMAKE_SKIP_BUILD_RPATH was disabled, we can now run
the checkPhase of cmake derivations without having to tweak the
LD_LIBRARY_PATH anymore.
    @knedlsepp @Artturin
    knedlsepp authored and Artturin committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    bcd7045 View commit details
    Browse the repository at this point in the history