-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add no-channel check #109543
ci: add no-channel check #109543
Conversation
2f5c395
to
6584ebc
Compare
6584ebc
to
cfdba72
Compare
I assume CI is needed because there is no different way to prevent people from pushing to these branches? |
I think admins ignore the branch protection. |
NixOS/ofborg#546 does similar to this with Being able to "require" |
I think the major concern there was that if ofborg would be not available the whole nixpkgs development would break. There are probably less concerns with github actions as there is a dedicated team with pager duty. |
Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
I marked this as stale due to inactivity. → More info |
* ci: add no-channel check * Update .github/workflows/no-channel.yml Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com> Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com> (cherry picked from commit b8297c0)
Tested and #130906 works as expected |
Motivation for this change
Somebody merged a change in
nixos-20.09
. See #109384Proposal
This is a proposal to prevent such issues in the future.
Here is how the error looks like:
And the branch protection change that would be put in place: