lib.meta: introduce availableOn
to check package availability on given platform
#114374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, a pattern
lib.any (lib.meta.platformMatch stdenv.hostPlatform) <some_pkg>.meta.platforms
is used to check whether a optional feature should be enabled by default. But it is incorrect since it doesn't checkmeta.badPlatforms
. This made package likesystemd
on riscv linux havekexectools
enabled, which doesn't support riscv, leading to an failure. (Related #101651)This PR replace the pattern with a new function
availableOnPlatform
to check bothmeta.{platforms,badPlatforms}
.This PR does NOT cause any rebuilds for currently non-broken packages.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)