Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: Run sandbox tests #118298

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Conversation

roberth
Copy link
Member

@roberth roberth commented Apr 2, 2021

Run the sandbox tests for stable nix on linux too.

To find problems like this earlier: NixOS/nix#4659

This problem was revealed in #118128 (comment)

    common.sh: line 89: unshare: command not found

This PR does not fix that PR, but improves nix testing.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

on linux.

To find problems like this earlier: NixOS/nix#4659
@roberth roberth requested a review from cole-h April 2, 2021 08:55
@ofborg ofborg bot requested a review from edolstra April 2, 2021 09:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Apr 2, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 118298 run on x86_64-linux 1

1 package marked as broken and skipped:
  • nix-exec
2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
4 packages failed to build and already failed to build on hydra master:
  • dydisnix: log was empty
  • haskellPackages.update-nix-fetchgit: log was empty
  • libnixxml: log was empty
  • update-nix-fetchgit: log was empty
48 packages built:
  • bundix
  • cabal2nix
  • cachix
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • dep2nix
  • fusionInventory
  • go2nix
  • haskellPackages.cachix
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hercules-ci-cnix-expr
  • haskellPackages.hercules-ci-cnix-store
  • haskellPackages.nix-paths
  • hercules-ci-agent
  • lispPackages.quicklisp-to-nix
  • lispPackages.quicklisp-to-nix-system-info
  • nix (nixStable)
  • nix-bundle
  • nix-doc
  • nix-du
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-serve
  • nix-update
  • nix-update-source
  • nixStatic
  • nixos-generators
  • nixos-rebuild
  • nixos-shell
  • nixui
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • python39Packages.nix-kernel
  • python39Packages.nixpkgs
  • python39Packages.pythonix
  • vgo2nix
  • vulnix

@SuperSandro2000 SuperSandro2000 merged commit ac47295 into NixOS:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants