python3Packages.astropy: unbreak multiple modules #120874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The spectral-cube error looks to be caused by the radio-beam update (radio-astro-tools/spectral-cube#708) from 5446c0c / #117452 Build report after a86a447a87f3c93cf187e8432da5f32226a3d784: Result of 26 packages built:
|
rmcgibbo
force-pushed
the
astropy
branch
2 times, most recently
from
68ae1a5
to
a86a447
Compare
|
Built and tested on macOS. It looks go to me. |
smaret
approved these changes
Apr 28, 2021
10 tasks
fabaff
reviewed
May 4, 2021
|
Result of 4 packages failed to build:
22 packages built:
builder for '/nix/store/j2m7r8zkzbbzw4m9dsajmsmbkx5czwn9-python3.8-glymur-0.9.3.drv' failed with exit code 1; last 10 log lines:
tests/test_jp2k.py: 59 warnings
tests/test_printing.py: 1 warning
/build/source/glymur/jp2k.py:1084: DeprecationWarning: `np.int` is a deprecated alias for the builtin `int`. To silence this warning, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
rlevel = np.int(np.round(np.log2(step)))
-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info ============================
FAILED tests/test_jp2k.py::TestJp2k::test_thread_support - AssertionError: Fa...
======= 1 failed, 450 passed, 1 skipped, 61 warnings in 86.65s (0:01:26) ======= |
|
@fabaff: Unfortunately I cannot reproduce the glymur failure. It builds fine for me from this PR. It might be flaky? |
Could be. Local build of glymur is fine for me. |
10 tasks
|
Result of 26 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I noticed that a few astropy packages were broken since a recent mass update: https://rmcgibbo.github.io/mydra/post/nixpkgs-fdce3b59/
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)