Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inklecate: init at 1.0.0 #129591

Merged
merged 2 commits into from
Jul 9, 2021
Merged

inklecate: init at 1.0.0 #129591

merged 2 commits into from
Jul 9, 2021

Conversation

shrimpram
Copy link
Member

Motivation for this change

The Inklecate compiler does not exist in the nixpkgs repo. I (and 2.8k stargazers) find the ink language useful so adding its official compiler is sure to help some nix users

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" -- No packages depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@shrimpram
Copy link
Member Author

shrimpram commented Jul 8, 2021 •
edited
Loading

The error is The option lib.maintainers.shreerammodi.name' is used but not defined. Could be because the commit that updates the maintainers list is the latter commit, I'll try reordering them

@shrimpram shrimpram marked this pull request as ready for review July 8, 2021 02:30
@shrimpram
Copy link
Member Author

Let me know if it's merge-able and I'll squash

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 8, 2021 •
edited
Loading

Result of nixpkgs-review pr 129591 at 95b6a047 run on aarch64-linux 1

1 package built successfully:
  • inklecate
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/compilers/inklecate/default.nix:39:3:

       |
39 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 129591 at 95b6a047 run on x86_64-linux 1

1 package built successfully:
  • inklecate
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/compilers/inklecate/default.nix:39:3:

       |
39 |   installPhase = ''
   |   ^

@SuperSandro2000
Copy link
Member

The error is The option lib.maintainers.shreerammodi.name' is used but not defined. Could be because the commit that updates the maintainers list is the latter commit, I'll try reordering them

That shouldn't matter.

SuperSandro2000
SuperSandro2000 requested changes Jul 8, 2021
View reviewed changes
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/inklecate/default.nix Outdated Show resolved Hide resolved
@shrimpram
Copy link
Member Author

shrimpram commented Jul 8, 2021 •
edited
Loading

So sorry for all the errors, a lot of expressions currently in master use such code, which is what I based a lot of my expression off. All of the suggestions should be resolved as well as the maintainers name error from before.

@shrimpram shrimpram requested a review from SuperSandro2000 July 8, 2021 17:05
SuperSandro2000
SuperSandro2000 requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cna you please squash all the package related commits together? make sure to leave the maintainer one extra.

shrimpram added 2 commits July 8, 2021 22:36
@shrimpram
maintainers: add shreerammodi
529c7af
@shrimpram
inklecate: init at version 1.0.0
23a95af 
inklecate is a command line compiler for the ink language, which is used
to make interactive narrative / choose-your-own-adventure style games.

More information about the ink language can be found at
https://github.com/inkle/ink
@shrimpram shrimpram requested a review from SuperSandro2000 July 9, 2021 20:03
@SuperSandro2000 SuperSandro2000 merged commit 45fc7d4 into NixOS:master Jul 9, 2021
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shrimpram @r-rmcgibbo @SuperSandro2000 @Janik-Haag