inconsolata: revert to working unstable version #136647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update to an unstable version of google-fonts broke the Inconsolata monospace font in programs that use xft such as urxvt. This patch reverts some inconsolata back to a working version. cc @jakubgs @06kellyjac @petabyteboy @tu-maurice Signed-off-by: William Casarin <jb55@jb55.com>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-fix-broken-inconsolata-font-in-urxvt-on-21-05/13437/6 |
jakubgs
approved these changes
Sep 6, 2021
|
Another option would be to source from https://github.com/googlefonts/Inconsolata Also you might want to swap to |
|
Maybe add a link to this «interpretation-of-monospace» issue, and a note to switch back to the unified approach once the issue gets resolved? |
|
On Tue, Sep 07, 2021 at 09:57:28PM -0700, Michael Raskin wrote:
Maybe add a link to this «interpretation-of-monospace» issue, and a note to switch back to the unified approach once the issue gets resolved?
ah right, good point. will do.
|
malloc47
added a commit
to malloc47/config
that referenced
this pull request
Sep 26, 2021
Underlying bug: googlefonts/Inconsolata#42 As yet unmerged fix: NixOS/nixpkgs#136647 This PR can be reverted once this fixed is merged upstream.
|
Can we get this merged? It works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to an unstable version of google-fonts broke the Inconsolata
monospace font in programs that use xft such as urxvt. This patch reverts
some inconsolata back to a working version.
Alternative to #130209
See also:
googlefonts/Inconsolata#42
https://discourse.nixos.org/t/how-to-fix-broken-inconsolata-font-in-urxvt-on-21-05/13437
cc @jakubgs @06kellyjac @petabyteboy @tu-maurice
Signed-off-by: William Casarin jb55@jb55.com