Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/console: fix cross-compiling #142272

Merged
merged 1 commit into from
Oct 22, 2021
Merged

nixos/console: fix cross-compiling #142272

merged 1 commit into from
Oct 22, 2021

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Oct 20, 2021

Motivation for this change

Cross-compiling.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 20, 2021
@ju1m ju1m added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Oct 20, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 20, 2021
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 22, 2021

Can you tell me how do you test cross-compilation of NixOS modules? I want to try to avoid this sort of issues in the future.

@ju1m
Copy link
Contributor Author

ju1m commented Oct 22, 2021

Can you tell me how do you test cross-compilation of NixOS modules? I want to try to avoid this sort of issues in the future.

@rnhmjoj, sure, is this flake.nix example enough to help you?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 22, 2021

Yes, thank you!

@rnhmjoj rnhmjoj merged commit b1df6fe into NixOS:master Oct 22, 2021
@xaverdh
Copy link
Contributor

xaverdh commented Oct 22, 2021

does this pr mean that we are slowly working towards cross compiling a full nixos system? that would be really cool :)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 22, 2021

Well, PR are surely welcome and I'll try to be more careful, at least in my own modules.

@ju1m ju1m deleted the console branch October 22, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ju1m @rnhmjoj @xaverdh