Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala: use latest JDK #146861

Merged
merged 3 commits into from
Nov 29, 2021
Merged

scala: use latest JDK #146861

merged 3 commits into from
Nov 29, 2021

Conversation

liff
Copy link
Contributor

@liff liff commented Nov 21, 2021

Motivation for this change

Scala 2.12, 2.13 and 3.x support latest Java versions just fine and since sbt already defaults to latest jdk attribute anyway, it doesn’t seem necessary to override that for the standalone compilers.

Scala 2.11 doesn’t work, without workarounds, on Java 11 and later so that and 2.10 will go on using 8.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 26, 2021

@cole-h and another PR

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 28517d5 into NixOS:master Nov 29, 2021
@liff liff deleted the scala-jdk-updates branch November 29, 2021 12:37
@kubukoz
Copy link
Member

kubukoz commented Dec 20, 2021

Can this be backported to 21.11?

@github-actions
Copy link
Contributor

Successfully created backport PR #151691 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants