Pantheon: prepare for meson 0.61 #154837
Merged
Pantheon: prepare for meson 0.61 #154837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
With one last patch applied on elementary-screenshot, the test passed. |
bobby285271
force-pushed
the
pantheon-meson
branch
from
430367a to
b8cf273
Compare
|
@ofborg test pantheon |
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
i18n.merge_file has been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61
bobby285271
force-pushed
the
pantheon-meson
branch
from
b8cf273 to
d277f13
Compare
13 tasks
|
Result of 1 package marked as broken and skipped:
33 packages built:
|
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am not sure whether upstream will make some release for these fixes before elementary OS 7 so I opened this just to make sure if someone wants to bump meson, it won't break Pantheon. To build Pantheon with meson 0.61, apply this patch on top of this PR.
Packages mostly fails with "Function does not take positional arguments" when using meson 0.61. As what upstream change says,
i18n.merge_filehas been ignoring positional arguments for a time and explicitly rejects with error since meson 0.61, and actually this has been marked as deprecated in 0.60. So it is still a good idea to fetch these fixes in advance.To make sure at least nixosTests.pantheon passes:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes