-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Raspberry Pi packages #156005
Update Raspberry Pi packages #156005
Conversation
Possibly a dupe of #154389? Also, it might be worth adding |
Well, this is what happens when things take too long to merge. Either way, the last two commits need to be cherry-picked for Pi Zero 2 W support. |
Note that for the rpi firmware package, I had to switch the fetcher to fetchurl, disable unpacking to avoid some Darwin sha256 mismatch due to FS+unicode issues that I don't understand well enough to explain. You can steal that from my PR if you want the CI to go green for this PR. |
Co-authored-by: Zhaofeng Li <hello@zhaofeng.li>
Co-authored-by: Zhaofeng Li <hello@zhaofeng.li>
Co-authored-by: Zhaofeng Li <hello@zhaofeng.li>
This is effective on the Pi 400 and on newer board revisions of the Pi 4B. From the official documentation: > New Raspberry Pi OS images from Bullseye onwards come with > this setting by default. <https://www.raspberrypi.com/documentation/computers/config_txt.html>
Should we merge this now? |
I'm in favor of merging. |
I own a Raspberry Pi 4 B and a Raspberry Pi Zero 2 W. I have built an sdcard image for them with this two expressions:
Both generated an I can confirm both machines booted fine. I have not done more thorough tests, but I plan to use this images from now on. Let me know if you want me to do any other tests, or if you want me to streamline some nix expression I have pasted here for you to gather more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look okay.
Approving / Merging on the account of multiple successful reviews.
Motivation for this change
This supersedes #144649 by @leo60228. Tested by booting an SD image on a Pi Zero 2 W:
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes