Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element-{desktop,}: 1.10.4 -> 1.10.6 #162907

Merged
merged 1 commit into from
Mar 8, 2022
Merged

element-{desktop,}: 1.10.4 -> 1.10.6 #162907

merged 1 commit into from
Mar 8, 2022

Conversation

sumnerevans
Copy link
Contributor

@sumnerevans sumnerevans commented Mar 5, 2022 •
edited
Loading

Motivation for this change

https://github.com/vector-im/element-web/releases/tag/v1.10.6

Closes #162733

Things done

Runs fine for me locally.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@sumnerevans sumnerevans requested a review from Ma27 March 5, 2022 15:48
newAM
newAM approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and runs on x86_64-linux NixOS, works great.

mweinelt
mweinelt approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me.

@mweinelt mweinelt merged commit a91212e into NixOS:master Mar 8, 2022
@github-actions github-actions bot mentioned this pull request Mar 8, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Successfully created backport PR #163343 for release-21.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newAM newAM newAM approved these changes

@mweinelt mweinelt mweinelt approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

element-{web,}: 1.10.6
4 participants
@sumnerevans @mweinelt @newAM @Ma27