Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosvm: add support for virgl_renderer{,_next} #165128

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

alyssais
Copy link
Member

Description of changes

This is a draft because the way I'm extracting the meson cross file from stdenv is unnacceptably horrible. We need a better way, e.g. the one in #159064.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 21, 2022
@alyssais alyssais force-pushed the crosvm-virglrenderer branch 3 times, most recently from 8f39ed8 to 7132f1e Compare July 15, 2022 10:06
@alyssais
Copy link
Member Author

Turns out we can just use the system virglrenderer, and avoid all the complexity and hacks. I wasn't sure this would work, because it won't be linked against minigbm, but it works fine in my testing with cross-domain virtio-gpu.

@alyssais alyssais marked this pull request as ready for review July 16, 2022 08:35
@alyssais alyssais merged commit 5df33d0 into NixOS:master Jul 23, 2022
@alyssais alyssais deleted the crosvm-virglrenderer branch August 9, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant