qtbase: use more than one core to build qmake
#168086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
SuperSandro2000
approved these changes
Apr 11, 2022
Done. |
|
Squashed. |
The qtbase package's `configurePhase` builds the `qmake` tool. In the current nixpkgs expression it does this single-threadedly, by invoking `make` without a `-j` flag. Let's thread `NIX_BUILD_CORES` through to `./configure`'s invocation of `make` via the `MAKEFLAGS` variable. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
|
@ofborg build qt5.qtbase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The qtbase package's
configurePhasebuilds theqmaketool. In the current nixpkgs expression it does this single-threadedly, by invokingmakewithout a-jflag.Let's thread
NIX_BUILD_CORESthrough to./configure's invocation ofmakevia theMAKEFLAGSvariable.On high-core-count machines the build of
qtbaseis much faster with this commit.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage