lib/systems/inspect.nix: add isPower64 #168111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an `isPower64` predicate to the two existing predicates for this architecture (`isPower` and `isPowerPC`). Note that `isPowerPC` matches only 32-bit machines, whereas `isPower` matches both 64-bit and 32-bit machines. Prior to this commit there was no single `isXXX` predicate for `powerpc64le`.
ofborg
bot
added
10.rebuild-darwin: 0
ghost
marked this pull request as ready for review
ghost
requested review from
alyssais,
nbp,
Ericson2314 and
matthewbauer
as code owners
ghost
mentioned this pull request
14 tasks
SuperSandro2000
approved these changes
Apr 11, 2022
|
Ping... I have a few other patches to submit which will fail CI without this one-liner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit adds an
isPower64predicate to the two existing predicates for this architecture (isPowerandisPowerPC).Note that
isPowerPCmatches only 32-bit machines (see also #168113), whereasisPowermatches both 64-bit and 32-bit machines. Prior to this commit there was no singleisXXXpredicate forpowerpc64.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes