-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv: use disallowedRequisites to check forbidden requisites #168590
Conversation
Result of 2 packages built:
|
Hrm, that doesn't sound right. This PR should cause absolutely everything to rebuild. Is there some way to get nixpkgs-review to not hide the build logs from me? This is the main reason I'm not in the habit of using it. A lot of my PRs are world-rebuilding things, and wasting ~6 hours build time because it was doing the wrong thing or doomed to fail is no fun. I can usually tell by watching |
I used |
This should wait until after staging reopens on 2022-May-15; the benefits are long-term and not worth the risk of breaking things right now. |
@amjoseph-nixpkgs Is this ready for merging? |
It should be, but since the PR is three months old let me run a rebuild real quick. I should have powerpc64le results in less than an hour and x86_64 results in about two hours. |
I suggest rebasing on staging if you didn't already do it locally |
Yes, that's where I'm building from. Unfortunately I got a nasty surprise and had to restart the build. Should be done in ~30 minutes. |
Yes, this PR is ready to merge.
|
Description of changes
This commit uses the
disallowedRequisites
derivation attribute tocheck the condition described in the comment above it: "avoid
reference to bootstrap tools".
Things done
./result/bin/
)