Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastly: init at v2.0.0 #170077

Closed
wants to merge 1 commit into from
Closed

fastly: init at v2.0.0 #170077

wants to merge 1 commit into from

Conversation

shyim
Copy link
Member

@shyim shyim commented Apr 24, 2022 •
edited
Loading

Description of changes

Added the Fastly CLI. Currently, there are only a terraform provider and a Prometheus exporter

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@shyim shyim requested a review from fabaff April 24, 2022 14:36
ereslibre
ereslibre approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this can be bumped to 3.1.0 already, +1. Can be bumped after this merges if desired.

@ereslibre
Copy link
Member

Result of nixpkgs-review pr 170077 run on x86_64-darwin 1

1 package failed to build:
  • fastly

@ereslibre
Copy link
Member

Result of nixpkgs-review pr 170077 run on x86_64-linux 1

1 package failed to build:
  • fastly

ereslibre
ereslibre suggested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sources are unfetchable, it has to be bumped.

@ereslibre ereslibre mentioned this pull request Jun 28, 2022
Merged
13 tasks
@ereslibre
Copy link
Member

Superseded by #179467

@ereslibre ereslibre closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre ereslibre requested changes

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyim @ereslibre @fabaff