Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken CMake-generated pkg-config files #172150
Fix broken CMake-generated pkg-config files #172150
Changes from 76 commits
9c6f916
fbd1b02
0764de0
5673ca3
a6d70f7
eeb7354
e867c55
2fbfcad
62011ff
25ec748
d7923ae
45e0d3c
ad65ea0
3fdaf9f
f9328d8
fb9aa5e
76e5d0c
d01ac37
91b6833
f23a7bc
852a7e2
cae7524
3a46bad
eed4382
bbb47fd
f74f367
c7757a2
a1b03a4
738e888
35a3c63
e84188c
3706b06
c627ccf
69ff649
d75acc0
34c8d45
5b3e94c
68ef94e
898f662
1b72d31
0652be6
32851a9
3687ae2
33c0932
2f5f9a9
333fa3a
7368d37
e05fc95
0c3abef
38d34ad
adfe4cf
ea7cbe0
243e996
a56ddc8
fea268e
42c2657
20dc199
77a4e90
f8c8b28
c839327
5eff4f4
e35cdb8
24518f6
6973a5a
b377ca5
41f554c
adc0fa6
759cf1e
339b4bd
ad3a58a
d558bef
12205df
1198abc
1dcc563
98ce40a
633b60b
75235b3
59ce8c2
b61acfb
2361850
ee37130
5b57746
acee5b1
f3b9a8a
bc2aee8
73a41bf
fd3435d
ad23326
8973b0a
df99db8
133a1ac
b06c284
7a925c8
372e946
61b4600
e935bf7
9f0567d
248292d
3688d1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(For this package specifically the fix is already committed and upstream promised a release soon so I’ll try and wait for that.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2.6.1 released:
https://sourceforge.net/p/drumstick/news/2022/05/drumstick-libraries-261-released-/
This problem with the pkg-config files should be solved, and also the need of a patch for locating the drumstick backends when CMAKE_INSTALL_LIBDIR has an absolute path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More than one month after a new upstream release has been published, nobody has bothered to upgrade the NixOS package, neither @alexshpilkin has updated his patch.
cc: @dotlambda: this is why I think that flathub/flatpak and friends are fixing a fundamental flaw of conventional Linux packaging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrolcl You can see I bet on fixing all of the brokenness at once. The delay is because I lost: among the problematic packages is
google-cloud-cpp
, where the maintainer, commendably, went for a substantial refactor rather than patch over the couple dozen autogenerated files as they had them, but now I need to bump it three versions and figure out C++ ABI compatibility and each failing compile takes several hours on my scruffy i5. I haven’t yet got back to that unpleasantness, that’s all. I know it’s a poor response to the quick fixes I received from yourself and quite a number of others, but my emotional capacity has been extremely limited as of late. I am sorry, for what it’s worth.(The benefits and drawbacks of having a packager intermediate between the author and the user have been extensively flamed elsewhere—hell if I know how I’m going to patch glslang and shaderc, which decided to vendor broken headers I otherwise already fixed—but in any case Nixpkgs, unlike Debian or Fedora or even FreeBSD ports, does not have a coherent team of package maintainers, so it’s perfectly normal for anyone to submit a version bump. If there hasn’t been one, then nobody either had a need for it or knew enough to make it. That is the price for having what’s probably the most extensive collection of packages in existence, and it’s not going to be acceptable to everyone.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#179594
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nobody cares about drumstick in NixOS, then there is an easier solution: remove it. The problem is that other projects depend on it. I hope that @orivej cares about VMPK and kmetronome.
I don't use NixOS myself, but I am a developer of the package we are talking about. I have no plans of packaging my projects for all and every Linux distro out there. For me Flathub is a perfect solution: I only have to care about a single repository, and I can offer all my projects even if they are all niche products.
@dotlambda: another problem with the Linux distros is the niche applications. They are often excluded from the repositories. There are 232987 projects known to repology (because they are at least in one repository). The the topmost repository by number of projects is nixpkgs unstable with 72002 projects (31% of the total).
Here is an example of a niche application: dmidiplayer available for FreeBSD, MacOS, and Windows, but excluded of most Linux distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I saw that NixOS was patching my library sources, I've included another fix in the release 2.6.1
I don't know if the new version with the old patch that is still being applied works, but any way you are risking that the patch don't apply in a future release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to. That's the job of packagers. If users want a package for a specific distro, let them request it to the distro maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can always happen and then the patch needs to be adjusted in the next update. Not a problem and pretty normal.