Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcb2gcode: enableParallelBuilding = true #172171

Closed
wants to merge 1 commit into from
Closed

pcb2gcode: enableParallelBuilding = true #172171

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2022

Description of changes

Enable parallel building for pcb2gcode.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin
Copy link
Member

@ofborg build pcb2gcode

@Artturin
Copy link
Member

build failure on linux

@ghost
Copy link
Author

ghost commented May 15, 2022

build failure on linux

really?

I see "All checks have passed 5 skipped, 22 successful, and 1 neutral checks".

Does the github web UI show you something different?

@ghost ghost closed this Jun 19, 2022
@Artturin
Copy link
Member

build failure on linux

really?

I see "All checks have passed 5 skipped, 22 successful, and 1 neutral checks".

Does the github web UI show you something different?

The neutral is the one that failed

https://github.com/NixOS/nixpkgs/pull/172171/checks?check_run_id=6351245691

The build succeeded one time and not the other so the build is not parallel friendly

@ghost ghost deleted the pr/pcb2gcode-parallel branch January 23, 2024 06:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant