Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psensor: add -Wno-error due to increasing compiler strictness #172177

Merged
merged 1 commit into from May 9, 2022
Merged

psensor: add -Wno-error due to increasing compiler strictness #172177

merged 1 commit into from May 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2022

ZHF: #172160

Description of changes

This Hydra failure:

https://hydra.nixos.org/log/iq8zqmw7yclgwpvr8i8clwf2sh67jb0i-psensor-1.2.1.drv

...appears to be the result of the package shipping with -Werror and
gcc accreting ever-increasing quantities of warnings as time
progresses. Let's not treat the compiler warnings as errors.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This Hydra failure:

  https://hydra.nixos.org/log/iq8zqmw7yclgwpvr8i8clwf2sh67jb0i-psensor-1.2.1.drv

...appears to be the result of the package shipping with -Werror and
gcc accreting ever-increasing quantities of warnings as time
progresses.  Let's not treat the compiler warnings as errors.
@ghost
Copy link
Author

ghost commented May 9, 2022

The ZHF announcement PR says: "Please ping @NixOS/nixos-release-managers on the PR and add the 0.kind: build failure label to the pull request. If you're unable to because you're not a member of the NixOS org please ping @dasJ, @tomberek, @jonringer, @Mic92"

I am unable to add this build label, so I therefore am issuing this ping.

@ghost ghost changed the title psensor: add -Wno-error due to increasing compiler strictness (ZHF) psensor: add -Wno-error due to increasing compiler strictness May 9, 2022
@davidak
Copy link
Member

davidak commented May 9, 2022

Result of nixpkgs-review pr 172177 run on x86_64-linux 1

1 package built:
  • psensor

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Builds, works

Thank you!

@davidak davidak merged commit af2ea9a into NixOS:master May 9, 2022
@ghost ghost deleted the pr/psensor-fix-zhf branch January 23, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant