ber_metaocaml: n107 -> n111 #173816
Merged
ber_metaocaml: n107 -> n111 #173816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
reviewed
May 25, 2022
| [ "-x11lib" x11lib | ||
| "-x11include" x11inc | ||
| "-flambda" | ||
| [ "--enable-flambda" |
There was a problem hiding this comment.
Why is this flambda option guarded by the useX11 condition? It seems unrelated…
There was a problem hiding this comment.
The formatting is now also weird. This could easily be in one line.
There was a problem hiding this comment.
The formatting is now also weird. This could easily be in one line.
Fixed.
There was a problem hiding this comment.
Why is this
flambdaoption guarded by theuseX11condition? It seems unrelated…
I'm afraid I have no idea. I was hesitant to make a functionality change in a version-bumping PR, but if you prefer I would be happy to remove the --enable-flambda.
The configure script has changed and no longer seems to provide a way to specify the location of the x11 libraries or headers. Therefore these configure options have been dropped.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The configure script has changed and no longer seems to provide a way
to specify the location of the x11 libraries or headers. Therefore
these configure options have been dropped.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)