Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm-trusted-firmware: set unfreeIncludeHDCPBlob=false if not used #175372

Closed
wants to merge 1 commit into from
Closed

arm-trusted-firmware: set unfreeIncludeHDCPBlob=false if not used #175372

wants to merge 1 commit into from

Commits on May 29, 2022

  1. arm-trusted-firmware: set unfreeIncludeHDCPBlob=false if not used

    The `unfreeIncludeHDCPBlob` parameter was introduced as a result of
    this reviewer request:
    
       #148890 (comment)
    
    The default value `unfreeIncludeHDCPBlob?true` causes a change in the
    `meta.license` field for all of the subpackages within
    `pkgs/misc/arm-trusted-firmware/`, and results in them needing
    `NIXPKGS_ALLOW_NONFREE=1`.
    
    For Rockchip platforms this change is unavoidable; we are correcting
    an incorrect license declaration.  However for non-Rockchip platforms
    the file `hdcp.bin` does not get included in the output.  Therefore we
    can set `unfreeIncludeHDCPBlob=false` on these platforms and produce
    no user-visible change in the resulting output, while preserving the
    ability to build them without `NIXPKGS_ALLOW_NONFREE=1`.
    
    Let's do that.
    Adam Joseph committed May 29, 2022
    Configuration menu
    Copy the full SHA
    3aaba92 View commit details
    Browse the repository at this point in the history