Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchgit: change allowedRequisites default from null to [] #178831

Closed
wants to merge 1 commit into from
Closed

fetchgit: change allowedRequisites default from null to [] #178831

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2022

This is not ready to be merged yet!

Writing the one-line commit for this PR was the easy part. The hard part is making sure I don't break nixpkgs eval for a ton of people. I will undraftify this when I have made sure, and explain the process (which will be mostly
this) once I have done so.

This draft PR is mainly a way of putting this task on my nixpkgs to-do list. However comments are welcome, including comments that say "this is a dumb idea".

Description of changes

As originally suggested in #177326, and as further encouraged here, this commit changes the default allowedRequisites of fetchgit from null (any requisites allowed) to [] (no requisites allowed unless overridden).

Commit Message
fetchgit: change allowedRequisites default from null to []

If this commit broke eval for your package:

1. I apologize!

2. Please try adding `allowedRequisites=null` to your fetcher.

3. If (2) does not work, do not hesitate to revert this commit and
   ping @a-m-joseph to let me know I need to investigate.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

If this commit broke eval for your package:

1. I apologize!

2. Please try adding `allowedRequisites=null` to your fetcher.

3. If (2) does not work, do not hesitate to revert this commit and
   ping @a-m-joseph to let me know I need to investigate.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 24, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2023
@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the pr/fetchgit/allowedRequisites-defaultEmptyList branch October 22, 2023 07:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: fetch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants