go,goBuildModules: bump default go version to 1.18 #179622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
broken on target branch:
all failed packages in the upcomming nixpkgs-review post I double checked if they where really broken, pinned them to go 1.17 or for unrelated or already broken packages ignored them. I also ignored everything cuda related because the source download (>2GB) is always failing for me. |
|
ipget: #179670 Will get to the others at some other point |
rski
reviewed
Jun 30, 2022
rski
reviewed
Jun 30, 2022
rski
reviewed
Jun 30, 2022
rski
reviewed
Jun 30, 2022
|
(moved my comments inline, duh) |
|
Result of 27 packages marked as broken and skipped:
86 packages failed to build:
1557 packages built:
|
|
This looks fine to me, I'll let someone else give the final approval. I do think we can either fix or drop all the remaining packages, that can be left as future work over the next couple of weeks before 1.19 comes out |
SuperSandro2000
force-pushed
the
go-1-18
branch
2 times, most recently
from
d8e04c5
to
0a80c84
Compare
|
@ofborg eval |
|
Have you checked all What are you planning to do about all darwin breakage on x86_64? Leaving contributors to figure out how to deal with dozens of broken and unfixable packages doesn't seem like a good idea. I'd suggest doing a hydra run just for |
I checked some and then determined that they won't change after none of my test examples changed. Edit: Currently double checking with the current rebuilds. If we don't get a hash mismatch then this will be safe. wget https://gist.githubusercontent.com/GrahamcOfBorg/41d3704882eceb3aa9de0c53f89bb298/raw/3c7143944161f0653dced2159bb4cd913a23d043/Changed%2520Paths
rg x86_64-linux Changed%20Paths | awk '{print $2}' | rg -v -e ^python310Packages -e ^python39Packages -e ^linuxKernel -e ^linuxPackages | xargs -I{} nix build --rebuild .#{}.go-modules
I pinged them in the darwin channel 5 days ago, 3 days ago and just now. So far I didn't receive any feedback. The Go 1.18 update is already stalled for a good amount of time and I don't want to make it another project held back by proprietary darwin. Lets wait a few days if someone provides feedback, otherwise I would just move ahead. |
|
Here goes nothin! |
|
the nix-rebuild comment doesn't look right to me, the --rebuild flag seems to only be part of |
|
really? ufff... |
13 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes