Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-bootstrap-tools-cross: enable Hydra builds of mips32el bootstrap-files #179628

Merged
merged 1 commit into from Jul 27, 2022
Merged

make-bootstrap-tools-cross: enable Hydra builds of mips32el bootstrap-files #179628

merged 1 commit into from Jul 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2022

Now that Hydra builds of the mips64el bootstrap-files are succeeding and the MIPS patchelf fix is merged, mips32el is the next low-hanging fruit. Mips32 accounts for the vast majority of OpenWRT hardware out there.

Will undraftify as soon as my verification build finishes. Verified.

Description of changes

This one-line commit will cause Hydra to build a bootstrap-files tarball for 32-bit little-endian MIPS.

Things done
  • Built on platform(s)
    • powerpc64le-linux
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

…-files

This one-line commit will cause Hydra to build a bootstrap-files
tarball for 32-bit little-endian MIPS.
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jun 29, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 29, 2022
@ghost ghost marked this pull request as ready for review June 29, 2022 22:35
@ghost
Copy link
Author

ghost commented Jul 27, 2022

Ping @vcunat @dezgeg

@vcunat vcunat merged commit a0e2bde into NixOS:master Jul 27, 2022
@ghost ghost deleted the pr/mips32/hydra-bootstrap-files branch July 27, 2022 16:04
@vcunat
Copy link
Member

vcunat commented Jul 27, 2022

Well, Hydra does cross from x86_64-linux and that apparently doesn't work: https://hydra.nixos.org/eval/1773176#tabs-new

@ghost
Copy link
Author

ghost commented Jul 27, 2022

Please merge #170736. I have it in my local tree which is why I did not get the failure that Hydra got.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant