-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken CMake-generated pkg-config files #181875
Merged
Merged
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
61bffac
zxing: fix paths in pkg-config file
alexshpilkin 1554ab5
gst_all_1.gst-plugins-bad: link with zxing-cpp
alexshpilkin 2ddb885
spirv-tools: fix paths in pkg-config files
alexshpilkin aa473c6
libjxl: fix paths in pkg-config files
alexshpilkin 1024921
wildmidi: fix paths in pkg-config file
alexshpilkin 7baca96
usrsctp: fix paths in pkg-config file
alexshpilkin 869539e
openalSoft: update homepage URL
alexshpilkin 4f7b421
openalSoft: fix paths in pkg-config file
alexshpilkin 52938dd
libebur128: fix paths in pkg-config file
alexshpilkin 5b12efa
openobex: fix paths in pkg-config file
alexshpilkin ca04904
ffmpegthumbnailer: fix path in pkg-config file
alexshpilkin 5dedecf
libmatroska: fix paths in pkg-config file
alexshpilkin a693b0c
extra-cmake-modules: fix paths in generated pkg-config files
alexshpilkin bb1d2fa
libebml: fix paths in pkg-config file
alexshpilkin d5ad233
libargs: fix path in pkg-config file
alexshpilkin 89f39f5
arrow-cpp: fix paths in CMake and pkg-config files
alexshpilkin 427ae9a
bcc: fix path in pkg-config file
alexshpilkin da6a954
bcg729: fix path in pkg-config file
alexshpilkin 3bf5a3c
cglm: fix paths in pkg-config file
alexshpilkin 6f1dd9a
cm256cc: fix path in pkg-config file
alexshpilkin 23fa3f2
cog: fix path in pkg-config file
alexshpilkin 4f04707
cxxopts: fix path in pkg-config file
alexshpilkin 44acd93
plasma5Packages.drumstick: fix paths in pkg-config files
alexshpilkin 092a1ea
eccodes: fix paths in pkg-config files
alexshpilkin 1c09946
entt: fix path in pkg-config file
alexshpilkin 499b90f
gbenchmark: fix paths in pkg-config file
alexshpilkin 0035e65
getdns: fix paths in pkg-config file
alexshpilkin f2e74c1
google-cloud-cpp: fix paths in pkg-config files
alexshpilkin 7b77d68
libbaseencode: fix paths in pkg-config file
alexshpilkin e1adfee
libbtbb: fix paths in pkg-config file
alexshpilkin d1f14fa
libcork: fix paths in pkg-config file
alexshpilkin 3bbc6d7
libcotp: fix paths in pkg-config file
alexshpilkin 722cacf
libdnf: fix path in pkg-config file
alexshpilkin ad67699
libkeyfinder: fix paths in pkg-config file
alexshpilkin 3481609
lxqt.lxqt-build-tools: fix paths in generated pkg-config files
alexshpilkin 0fb6766
libmodule: fix paths in pkg-config file
alexshpilkin 4c5e1c7
libnats-c: fix path in pkg-config file
alexshpilkin 50cee47
libquotient: fix paths in pkg-config file
alexshpilkin 91bbd95
libsurvive: fix path in pkg-config file
alexshpilkin e7b9363
libtorrent-rasterbar: fix paths in pkg-config file
alexshpilkin c29cb15
libtsm: fix paths in pkg-config file
alexshpilkin 4523fb5
libunarr: fix paths in pkg-config file
alexshpilkin 32e540e
maliit-framework: fix paths in pkg-config files
alexshpilkin 3e6abe1
mysocketw: fix path in pkg-config file
alexshpilkin e3d63b7
nanomsg: fix path in pkg-config file
alexshpilkin b3d9858
notcurses: fix paths in pkg-config files
alexshpilkin 96a487c
obexftp: fix paths in pkg-config file
alexshpilkin c709dd4
olm: fix paths in pkg-config file
alexshpilkin d6ad6c4
opencolorio: fix path in pkg-config file
alexshpilkin 8b387ff
opendht: fix paths in pkg-config file
alexshpilkin cb3a81d
openxr-loader: fix path in pkg-config file
alexshpilkin bf76af5
orcania: fix paths in pkg-config file
alexshpilkin 5c42107
powercap: fix paths in pkg-config file
alexshpilkin ce8e657
proj: fix paths in CMake and pkg-config files
alexshpilkin 00b5281
rabbitmq-c: fix paths in pkg-config file
alexshpilkin 73f88f1
recastnavigation: fix paths in pkg-config file
alexshpilkin e059421
reproc: fix paths in pkg-config files
alexshpilkin 7a2593d
rinutils: fix path in pkg-config file
alexshpilkin d5f218a
rnp: fix path in pkg-config file
alexshpilkin 2e07f8a
rocm-thunk: fix paths in pkg-config file
alexshpilkin a6ef202
seexpr: fix path in pkg-config file
alexshpilkin 18c0a8b
sentencepiece: fix paths in pkg-config file
alexshpilkin 02f6b12
shadowsocks-libev: fix paths in pkg-config files
alexshpilkin 9d05c94
soapysdr: fix paths in pkg-config file
alexshpilkin 2d03092
spdlog: fix path in pkg-config file
Artturin ab2ace0
spirv-headers: fix path in pkg-config file
alexshpilkin 960e3c4
tdlib: fix paths in pkg-config files
alexshpilkin 347b676
tinyobjloader: fix paths in pkg-config file
alexshpilkin 89f5bb4
libbaseencode: 1.0.12 -> 1.0.14
alexshpilkin 9b66b71
libcotp: 1.2.4 -> 1.2.6
alexshpilkin 6a0a4f9
xsimd: fix path in pkg-config file
alexshpilkin a2a8c38
xtensor: fix path in pkg-config file
alexshpilkin 00c23f4
libzra: fix paths in pkg-config file
alexshpilkin 3643102
libiio: 0.21 -> 0.23
alexshpilkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 6 additions & 1 deletion
7
pkgs/development/libraries/kde-frameworks/extra-cmake-modules/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexshpilkin
''${something}
is the proper way to escape${
Please confirm If that is what you were trying to do then I'll change them all to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that wasn’t it. This is more clever than I would like, but it has a purpose: there are two levels of escaping here, from Nix when it’s generating the script and from Bash when it’s executing it. That is to say, the file we’re patching contains the literal string
${exec_prefix}/@CMAKE_INSTALL_LIBDIR@
in it—the${...}
is not shell syntax, it is pkg-config syntax. If you wanted to do this with standard Nix escaping as you suggest, you would end up with\''${exec_prefix}
or'''${exec_prefix}'
, which is less subtle but even harder to parse I think.(This is when .in files are being patched; take care that in some cases, CMake sources are being patched instead—so the interpolation is passing through Nix, Bash, and CMake on the way to the pkg-config file—and the CMake file being patched is already escaping the variable reference in one of a couple ways I’ve seen.)
If you see a clearer way, go for it, but the change you’re suggesting here wouldn’t work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, do you think this is ready to merge?