Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv2: disable addition-overflow test on isPower64 too #183116

Closed
wants to merge 1 commit into from
Closed

exiv2: disable addition-overflow test on isPower64 too #183116

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2022

Description of changes

This test seems to depend on x86{_64} arithmetic overflow behavior; it is disabled for Arm{32,64} and fails on powerpc64le as well. All other tests pass on powerpc64le.

Things done
  • Built on platform(s)
    • powerpc64le-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 27, 2022
@ghost ghost marked this pull request as draft August 13, 2022 01:31
@ghost ghost marked this pull request as ready for review August 13, 2022 01:31
@ghost
Copy link
Author

ghost commented Aug 13, 2022

Resolved merge conflicts.

This test seems to depend on x86{_64} arithmetic overflow behavior; it
is disabled for Arm{32,64} and fails on powerpc64le as well.  All
other tests pass on powerpc64le.
@ghost ghost marked this pull request as draft September 1, 2022 05:39
@Artturin
Copy link
Member

Exiv2/exiv2#933 (comment)

The newest version in main branch passes all tests on riscv64. However, it's hard to find which commit fixes this. Hope a new version can be released soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant