nixos/teeworlds: migrate to rfc42 settings #185492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
hax404
force-pushed
the
teeworlds_rfc42
branch
2 times, most recently
from
f78961e
to
64eb620
Compare
ncfavier
requested changes
Jan 24, 2023
| description = lib.mdDoc '' | ||
| See [Teeworlds Documentation](https://www.teeworlds.com/?page=docs&wiki=server_settings) for all configuration options. | ||
| ''; | ||
| type = lib.types.submodule { |
There was a problem hiding this comment.
This needs a freeformType. Probably something like attrsOf (nullOr (oneOf [ str int bool ])). bool should be mapped to 0/1, null shouldn't be emitted.
| }; | ||
|
|
||
| sv_register = mkOption { | ||
| type = types.int; |
There was a problem hiding this comment.
If we change the type, we should use mkChangedOptionModule; however here we should keep this as bool and map to 0/1 when writing the config.
|
|
||
| extraOptions = mkOption { |
There was a problem hiding this comment.
We should keep this for backwards compatibility and append those lines to the generated config. Maybe add a warning to switch to settings if extraOptions is defined.
| example = [ "sv_map dm1" "sv_gametype dm" ]; | ||
| settings = mkOption { | ||
| default = {}; | ||
| example = literalExpression '' |
There was a problem hiding this comment.
literalExpression is not needed here.
| @@ -1,96 +1,116 @@ | |||
| { config, lib, pkgs, ... }: | |||
| { config, lib, options, pkgs, ... }: | |||
hax404
force-pushed
the
teeworlds_rfc42
branch
from
64eb620
to
f831afe
Compare
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
related: #144575
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes