-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btrfs-progs: allow to build without python bindings #186527
Conversation
@ofborg eval |
Hm, it sounds like the second commit does more than the commit message claims and then the third commit undos the part actually in the commit message? Maybe squash then? |
Yeah sorry the second commit was made in order to reduce the rebuilds to zero (so ofborg would remove the "red oval of shame" from my PR), and then the third commit reverted some parts of the second commit that turned out not to be necessary. In any event: squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge conflict resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seems you merged master into your branch. Could you please make a rebase on master instead.
Python cross-compilation is quite difficult, and doesn't work in several situations, such as: #186525 Let's give people the option of cross-compiling `btrfs-progs` to hostPlatforms for which we cannot cross-compile python. Unfortunately btrfs-progs insists on a special configure flag `--disable-python`; simply being unable to find python isn't enough.
Result of |
Done. |
Description of changes
Python cross-compilation is quite difficult, and doesn't work in several situations, such as:
#186525
Let's give people the option of cross-compiling
btrfs-progs
to hostPlatforms for which we cannot cross-compile python. Unfortunately btrfs-progs insists on a special configure flag--disable-python
; simply being unable to find python isn't enough.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)