nixos/vaultwarden: Bind to localhost by default #188644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
hax404
reviewed
Aug 28, 2022
bjornfor
reviewed
Aug 29, 2022
|
@nh2 Do you mind rebasing and making the requested changes? |
SuperSandro2000
added
the
2.status: merge conflict
nh2
force-pushed
the
vaultwarden-default-localhost
branch
from
97f4816 to
080757c
Compare
|
I rebased and did the suggested changes, merging. |
ofborg
bot
removed
the
2.status: merge conflict
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Web services should listen to localhost by default, see #100192. Especially because Vaultwarden's own docs recommend to host it behind a reverse proxy only (see link in the same option's example text).
Things done
nixos/doc/manual/md-to-db.shto update generated release notes