pcre: fix on ppc(64) #189278
Closed
pcre: fix on ppc(64) #189278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, tests fail on bad readback & segfaults.
|
There is still some other ppc64 stdenv stuff that needs to be upstreamed. The bootstrap files, teaching the bintools wrapper where to find the libc and teaching openssl 1.x & the python wrapper about gnuelfabiv2 are the ones I have locally. I was stuck on ELF ABI problems for awhile but the recent #182807 helped alot with that. bootstrap files were started in #177001, @minijackson iunno how much more you have lined up for PRs already but I hope I'm not stepping on your toes too much by opening afew drafts! I'm very excited about ppc64 support 😅. |
|
Ehh, I think I fumbled this pretty hard. Lemme close this for now and come back when some more basic stuff is merged. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a patch taken from Void Linux: https://github.com/void-linux/void-packages/blob/8e1eceec431ab3d3d6e469ad0680ce74e46f8be3/srcpkgs/pcre/patches/ppc-icache-flush.patch. I tried to
fetchpatchit like I would on a regular package but it didn't eval, don't remember the error right now. I'll check again later.Without this patch, the pcre test suite fails on my machine. Excuse the slightly off look, the colours on the distro I'm using don't capture correctly.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes