Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser-bundle-bin: add comment explaining allowSubstitutes=false #192205

Closed
wants to merge 1 commit into from
Closed

tor-browser-bundle-bin: add comment explaining allowSubstitutes=false #192205

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2022

Closed by #192220

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The comments added by this commit are my summary of @joachifm's (very patient)
explanation of the reason for hydraPlatforms=[] (bandwidth) and
allowSubstitutes=false; (don't bother checking because it isn't on
cache.nixos.org anyways).

The comments added by this commit are my summary of @joachifm's (very patient)
explanation of the reason for hydraPlatforms=[] (bandwidth) and
allowSubstitutes=false; (don't bother checking because it isn't on
cache.nixos.org anyways).
ghost referenced this pull request Sep 21, 2022
To better support users that are unable to access the official Tor
distribution site, e.g., #26184
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 21, 2022
@ghost
Copy link
Author

ghost commented Sep 21, 2022

More details here: https://discourse.nixos.org/t/why-is-caching-for-tor-browser-bundle-bin-disabled/16499/2

and in the commit message for ecd0e1a

I'll revisit this in the morning and either add more information or close it.

@ghost ghost marked this pull request as draft September 21, 2022 09:45
@SuperSandro2000
Copy link
Member

The source is only a small 108M and the final build 251M which should not make any difference for hydra or the CDN. Also this is a recuring problem, so I firmly believe we try to save bandwidth at the wrong point here. Closing and removing that from meta in my PR.

@ghost ghost deleted the pr/torbrowser/explain branch January 23, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant