Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-lint: 6.5.2 -> 6.7.0 #192919

Merged
merged 1 commit into from
Sep 30, 2022
Merged

ansible-lint: 6.5.2 -> 6.7.0 #192919

merged 1 commit into from
Sep 30, 2022

Conversation

stasjok
Copy link
Contributor

@stasjok stasjok commented Sep 25, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from SuperSandro2000 and sengaya September 25, 2022 17:50
@tjni
Copy link
Contributor

tjni commented Sep 25, 2022

This has been updated to 6.5.2 already on staging-next. I'm not sure the best way to resolve this if you need 6.7.0 ASAP but thought I would let you know.

@mweinelt
Copy link
Member

mweinelt commented Sep 25, 2022 •
edited
Loading

Probably best to wait for staging-next to reach master within the next 48 hours. #191339

sengaya
sengaya approved these changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@sengaya sengaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested on macOS

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 25, 2022
@stasjok stasjok changed the title ansible-lint: 6.4.0 -> 6.7.0 ansible-lint: 6.5.2 -> 6.7.0 Sep 29, 2022
@ofborg ofborg bot requested review from SuperSandro2000 and sengaya September 29, 2022 08:18
@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 29, 2022
@sengaya sengaya mentioned this pull request Sep 29, 2022
Closed
@marsam marsam merged commit 6aa30e6 into NixOS:master Sep 30, 2022
@stasjok stasjok deleted the ansible-lint-6.7.0 branch January 11, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjni tjni tjni left review comments

@mweinelt mweinelt mweinelt left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@sengaya sengaya Awaiting requested review from sengaya

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stasjok @tjni @mweinelt @sengaya @SuperSandro2000 @marsam @bobby285271