You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change invokes bash interpreter directly on make.bash script. This allows using overrideAttrs with dontPatch set to true as a workaround for issue #125198.
The package also now keeps the regexp/syntax/make_perl_groups.pl file since it is not used by the test suite and it is confusing when some files present in upstream src tree are missing.
Things done
Built on platform(s)
x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
Can we move patchShebangs instead as I suggested in #193458 (comment)?
Assuming dontPatch = true, wouldn’t that potentially cause unexpected side effects (e.g. patching some codegen scripts in GOROOT), especially since Go builds just fine without patches?
Could just need to check if (go.overrideAttrs (prev: { patchPhase = false; })) works, then we don't need to make any changes (apart from the perl file).
Having thought about this some more I don't think bash make.bash should be merged anyway, it is a workaround for a problem that has only been created by using dontPatch = true;.
Why buildPhase (and patchPhase for that matter) should patch shebangs even if it not necessary for the build instructions? Isn’t that part of the default fixupPhase and controlled with dontPatchShebangs?
This change keeps the regexp/syntax/make_perl_groups.pl file even though
it contains invalid shebang. It is not used by the test suite and there
is no reason to remove it. In fact, it is confusing when some files used
to generate Go code in standard library are missing in the package.
Honestly, I don’t see bash make.bash as a workaround, that’s how I’ve been building Go releases for years. That said, I’m fine with dropping that part of the PR, Nixpkgs is flexible enough so I can keep doing things how I’m used to on my machines without forcing my opinions on others.
Closing this as there was no feedback for some time and I’m no longer interested in this change — I’ve been using a custom unpatched Go derivation for builds (Go modules that are sometimes built by other developers that don’t use Nix), and it doesn’t really matter whether Go compiler used for programs in NixOS is patched or not.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tie
force-pushed
the
go-make-bash
branch
2 times, most recently
from
zowoq
changed the title
Description of changes
This change invokes bash interpreter directly on make.bash script. This allows using overrideAttrs with dontPatch set to true as a workaround for issue #125198.
The package also now keeps the
regexp/syntax/make_perl_groups.plfile since it is not used by the test suite and it is confusing when some files present in upstream src tree are missing.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes