Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vte: fix build on darwin #195998

Merged
merged 1 commit into from
Oct 14, 2022
Merged

vte: fix build on darwin #195998

merged 1 commit into from
Oct 14, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Oct 14, 2022

Description of changes

As in the title.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 14, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 14, 2022
@jtojnar
Copy link
Member

jtojnar commented Oct 14, 2022 •
edited
Loading

Also is there an upstream bug? I would expect Homebrew to suffer from this as well but with a quick search I only noticed https://gitlab.gnome.org/GNOME/vte/-/issues/2592.

@ofborg ofborg bot requested a review from jtojnar October 14, 2022 16:21
@wegank
Copy link
Member Author

wegank commented Oct 14, 2022

I think it is the same issue: now switching to -D_DARWIN_C_SOURCE.

@jtojnar
Copy link
Member

jtojnar commented Oct 14, 2022

Might be nicer to switch to https://gitlab.gnome.org/GNOME/vte/-/commit/1f1f177ff797ac2bb453168951135865cfded900.patch then. This would allow us to easily see when it is no longer necessary.

@ofborg ofborg bot requested a review from jtojnar October 14, 2022 17:32
@ofborg ofborg bot added 10.rebuild-linux: 101-500 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 14, 2022
@jtojnar jtojnar merged commit 4106bff into NixOS:master Oct 14, 2022
@jtojnar
Copy link
Member

jtojnar commented Oct 14, 2022

Thanks.

@wegank wegank deleted the vte-darwin branch October 14, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 Awaiting requested review from dasj19

@astsmtl astsmtl Awaiting requested review from astsmtl

@hedning hedning Awaiting requested review from hedning

@amaxine amaxine Awaiting requested review from amaxine

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @jtojnar