Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.zeroconf: disable tests on darwin #199518

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 4, 2022

Description of changes

The package is failing, with 106 failures and 9 errors on Hydra, but none on my machine. The error was reported a year ago upstream at python-zeroconf/python-zeroconf#967.

ZHF #199919.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 4, 2022
@ofborg ofborg bot requested a review from abbradar November 4, 2022 12:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2022
@mweinelt
Copy link
Member

mweinelt commented Nov 7, 2022

Looks like a race condition honestly, and if it affects aarch64-darwin it very likely also affects x86_64-darwin the same. I restarted the build on hydra and it completed this time. If we disable the tests, let's do it on both darwins.

@wegank wegank changed the title python3Packages.zeroconf: disable tests on aarch64-darwin python3Packages.zeroconf: disable tests on darwin Nov 7, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 7, 2022
@mweinelt mweinelt merged commit 75d0713 into NixOS:master Nov 7, 2022
@wegank wegank deleted the zeroconf-aarch64-darwin branch November 7, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants