Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libiio: allow build on systems without avahi #199959

Merged
merged 1 commit into from Nov 8, 2022
Merged

libiio: allow build on systems without avahi #199959

merged 1 commit into from Nov 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2022

Description of changes

#181875 seems to have made this
package and its downstream dependencies no longer build on
avahi-less systems. Let's make it possible for them to build again.

CC @Artturin

Things done

@wentasah
Copy link
Contributor

wentasah commented Nov 7, 2022

Code LGTM. However, the PR/commit title should not be about unbreaking, but about making avahi an optional dependency. To unbreak anything, one has to callPackage with avahiSupport = false.

#181875 seems to have made this
package and its downstream dependencies no longer build on
avahi-less systems.  Let's make it possible for them to build again.
@ghost ghost changed the title libiio: unbreak systems without avahi libiio: make it build on systems without avahi Nov 7, 2022
@ghost ghost changed the title libiio: make it build on systems without avahi libiio: allow build on systems without avahi Nov 7, 2022
@Artturin Artturin merged commit 2fe8fa4 into NixOS:master Nov 8, 2022
@ghost ghost deleted the pr/libiio/avahiSupport branch November 11, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants