Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: revive nix_2_6 #200357

Merged
merged 1 commit into from
Nov 10, 2022
Merged

nix: revive nix_2_6 #200357

merged 1 commit into from
Nov 10, 2022

Conversation

Profpatsch
Copy link
Member

The critical regression bug in
NixOS/nix#6572 does not appear (at least as often) in nix 2.6 according to the discussion there, so we need to allow people to pin this older version.

Partial revert of
b2eea05

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The critical regression bug in
NixOS/nix#6572 does not appear (at least as
often) in nix 2.6 according to the discussion there, so we need to
allow people to pin this older version.

Partial revert of
NixOS@b2eea05
@Profpatsch Profpatsch merged commit 90e7699 into NixOS:master Nov 10, 2022
@roberth
Copy link
Member

roberth commented Nov 14, 2022

Will be fixed properly soon with NixOS/nix#7283

@vcunat vcunat mentioned this pull request Dec 4, 2022
13 tasks
@Artturin
Copy link
Member

Artturin commented Dec 4, 2022

2_6 will be removed again in #204481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants