Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket-minimal: fix build on aarch64-darwin #203587

Merged
merged 1 commit into from
Nov 30, 2022
Merged

racket-minimal: fix build on aarch64-darwin #203587

merged 1 commit into from
Nov 30, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 29, 2022 •
edited
Loading

Description of changes

Closes #195086. / ZHF: #199919

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 29, 2022
Atemu
Atemu requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this fix the build on aarch64-darwin? Please explain what the change does in the commit message.

@wegank
racket-minimal: fix build on aarch64-darwin
8b868b5 
This commit fixed a previous patch so that signatures are effectively removed and then added.
@wegank wegank requested a review from Atemu November 29, 2022 15:28
marsam
marsam approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@marsam marsam merged commit b78d501 into NixOS:master Nov 30, 2022
@github-actions github-actions bot mentioned this pull request Nov 30, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #203737 for release-22.11.

@github-actions
Copy link
Contributor

Git push to origin failed for release-22.11 with exitcode 1

@wegank wegank deleted the racket-minimal-darwin branch November 30, 2022 12:23
shadaj added a commit to shadaj/nixpkgs that referenced this pull request Nov 30, 2022
@shadaj
racket: mark as unbroken on darwin
3b1c417 
NixOS#203587 fixed failures on darwin, so the package now builds fine
@shadaj shadaj mentioned this pull request Nov 30, 2022
Merged
13 tasks
github-actions bot pushed a commit that referenced this pull request Dec 1, 2022
@shadaj @github-actions
racket: mark as unbroken on darwin
bb50c31 
#203587 fixed failures on darwin, so the package now builds fine

(cherry picked from commit 3b1c417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@Atemu Atemu Awaiting requested review from Atemu

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Racket 8.6 broken on aarch64-darwin
3 participants
@wegank @marsam @Atemu