Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv.mkDerivation: check that depsBuildX are executable on the build system #204387

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

stdenv.mkDerivation: check that depsBuildX are executable on the build system #204387

wants to merge 7 commits into from

Commits on Jan 8, 2023

  1. wine: use stdenv_32bit for wine32 

    to make sure all things in nativeBuildInputs are executable on
buildPlatform

```
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
```

to

```
wine> checking build system type... x86_64-pc-linux-gnu
wine> checking host system type... x86_64-pc-linux-gnu
```

i don't know if this affects anything negatively but wine builds and the log output is similar but with stuff like `gcc -m32 ...` and `-m32` in other places

Weird things in the log are

```diff
checking for cups/cups.h... yes
checking for cups/ppd.h... yes
- checking for -lcups... libcups.so.2
+ checking for -lcups... not found
...
- configure: libcapi20 development files not found, ISDN won't be supported.
+ configure: libcapi20 32-bit development files not found, ISDN won't be supported.
+ configure: libcups 32-bit development files not found, CUPS won't be supported.
```

no diff in
```
nix-repl> pkgs = import ./. { system = "i686-linux"; }

nix-repl> pkgs.wine
«derivation /nix/store/lik48akxk5hk3hvbqhaxgsh0827kv3zd-wine-7.0.drv»
```
    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    ba64f7f View commit details
    Browse the repository at this point in the history

  2. mfcl3770cdw: use stdenv_32bit instead of pkgsi686Linux 

     ["trace: warning: dpkg-1.21.1ubuntu2.1 in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build", "trace: warning: hook in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build", "trace: warning: dpkg-1.21.1ubuntu2.1 in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build", "trace: warning: hook in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build"]

```
nix-repl> o = lib.lists.last wine.nativeBuildInputs

nix-repl> o
«derivation /nix/store/i7ya4lqal0awbgxrabkq70gx56skvax5-i686-w64-mingw32-stage-final-gcc-wrapper-11.3.0.drv»

nix-repl> stdenv.buildPlatform.canExecute o.stdenv.hostPlatform
true

nix-repl> pkgsi686Linux.stdenv.buildPlatform.canExecute o.stdenv.hostPlatform
false
```
    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    1387bbe View commit details
    Browse the repository at this point in the history

  3. pkgs/stdenv/generic/make-derivation.nix: run nixpkgs-fmt 

    allows us to use nixpkgs-fmt when editing this file making the editing
experience much better
    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    fc073c4 View commit details
    Browse the repository at this point in the history

  4. stdenv.mkDerivation: check that depsBuildX are executable on the buil… 

    …d system

```
nix-repl> pkgsCross.aarch64-multiplatform.keybinder.nativeBuildInputs
[ «derivation /nix/store/sxxk0g9gd18w9r28gbfx8wl65sr8liwm-aarch64-unknown-linux-gnu-pkg-config-wrapper-0.29.2.drv» «derivation /nix/store/ldbs4pw57hy3szqfh8ycskrgywpaahqs-autoconf-2.71.drv» trace: warning: automake-aarch64-unknown-linux-gnu-1.11.6 in keybinder's nativeBuildInputs not executable on build
«derivation /nix/store/yj8vj3gbd78scrj4xjmdx4rm5p87dyb9-automake-aarch64-unknown-linux-gnu-1.11.6.drv» ]
```
    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    f4e5fc2 View commit details
    Browse the repository at this point in the history

  5. perl: use self == __splicedPackages instead of perl and buildPerl

    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7e23b3b View commit details
    Browse the repository at this point in the history

  6. stdenv.mkDerivation: workaround hacks in perl cross-compilation

    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    27bc9f4 View commit details
    Browse the repository at this point in the history

  7. stdenv.mkDerivation: workaround

    @Artturin
    Artturin committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    6e027e0 View commit details
    Browse the repository at this point in the history