-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ponyc: 0.50.0 -> 0.52.2 #205521
ponyc: 0.50.0 -> 0.52.2 #205521
Conversation
Please remove the url from the commit message. Or at least put it on another line. |
I can do that, But I followed the example at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md. |
llvm patch removed upstream.
Um.. that's interesting, I'm not sure I (or 99% of contributors) got the memo over that change... |
Is what these darwin builds are doing normal? |
Not particularly unusual if e.g. a llvm-rebuilding PR has been merged recently. |
Oh hold on looks like ponyc has an embedded copy of llvm itself. Yes, I wouldn't expect ofborg to ever get enough time to build this. |
Firstly @dyercode, please accept my apology for not seeing the request for review for this until now. I found it as I was working on a PR to bring to 0.53.0 since 0.50.0 now won't compile due to dn.h (DECNet). Another issue has emerged via #213185 where the build additionally fails as it is unable to locate libstdc++.a using clang++. In other words, we can't do any updates to ponyc until that PR hits master. When that happens, I'm happy to send you all the changes I made to 0.53.0 so you can raise a new PR, or… I can just push it when the time comes. Regardless, please consider adding yourself to the maintainers :-) <3 |
I guess we can target staging-next? |
No worries. Was just something I was fiddling with for advent of code and seemed easy enough to contribute to save myself some recovers. LMK if you need me to do anything to this. |
Obsoleted by #220073 You know… if you want to add yourself to the maintainers we'd be happy to have you ♥ |
…g/0.52.2
llvm patch removed upstream.
Description of changes
Bump ponyc version.
google benchmarks updated to make compile. Step to apply an LLVM patch removed as in upstream ponylang/ponyc#4192
https://github.com/ponylang/ponyc/releases/tag/0.52.2
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes