Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iproute2: 6.0.0 -> 6.1.0 #206932

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

clerie
Copy link
Member

@clerie clerie commented Dec 19, 2022

Description of changes

"Nothing major; lots of usual set of small fixes."

Changes: https://marc.info/?l=linux-netdev&m=167103481006660

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
Copy link
Contributor

trofi commented Dec 24, 2022

The change looks good but it needs to target staging branch as it rebuilds too many packages for small master updates.

@clerie clerie changed the base branch from master to staging December 27, 2022 17:20
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)
And sorry for the huge delay :o

PS (for the future): If possible, please put the link to the announcement on the mailinglist in the commit message (it'll automatically get copied into the PR description and that way it is much quicker to recover via the Git CLI - at least I find that quite useful in such cases).

@primeos primeos merged commit ccb3146 into NixOS:staging Jan 4, 2023
@clerie
Copy link
Member Author

clerie commented Jan 5, 2023

@primeos Thank you for merging, I will try to apply your feedback on my next commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants