Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: 5.3.1 -> 6.0.0 #207041

Merged
merged 1 commit into from
Jan 4, 2023
Merged

harfbuzz: 5.3.1 -> 6.0.0 #207041

merged 1 commit into from
Jan 4, 2023

Conversation

2xsaiko
Copy link
Contributor

@2xsaiko 2xsaiko commented Dec 20, 2022 •
edited
Loading

Description of changes

Update HarfBuzz to version 6.0.0.

Closes #180054.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra December 20, 2022 20:54
@risicle
Copy link
Contributor

risicle commented Dec 21, 2022

passthru.tests build successfully on aarch64-linux apart from already-broken mapnik

@2xsaiko
Copy link
Contributor Author

2xsaiko commented Dec 21, 2022

Tests also build successfully on x86_64-linux and aarch64-darwin (including mapnik).

@alerque
Copy link
Contributor

alerque commented Jan 3, 2023

Is there anything in particular holding up this PR? We use Nix for a lot of things upstream at the SILE project and our next release milestone supporting variable fonts is a bit held up because we can't run CI tests remotely or rebuild our website examples easily without Nix support for HarfBuzz 6!

Also as a point of reference as an avid Arch Linux user I can report that the entire distro switched to 6.x pretty painlessly. There is no known breakage moving up from older releases.

@alerque alerque mentioned this pull request Jan 3, 2023
Merged
@risicle
Copy link
Contributor

risicle commented Jan 3, 2023

This will need to be re-targeted at staging using the technique described in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

@2xsaiko 2xsaiko changed the base branch from master to staging January 4, 2023 18:47
@risicle risicle merged commit 6f63cf8 into NixOS:staging Jan 4, 2023
@2xsaiko 2xsaiko deleted the outgoing/harfbuzz6 branch January 4, 2023 21:32
@alerque
Copy link
Contributor

alerque commented Jan 5, 2023

PR Tracker

@alerque alerque mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

@risicle risicle risicle approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harfbuzz's CMake config uses the wrong path
3 participants
@2xsaiko @risicle @alerque