Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itk: unstable -> 5.3.0 #207042

Merged
merged 1 commit into from
Dec 27, 2022
Merged

itk: unstable -> 5.3.0 #207042

merged 1 commit into from
Dec 27, 2022

Conversation

bcdarwin
Copy link
Member

Description of changes

Previously we had itk 5.2.1 and itk-unstable tracking the 5.3 branch (used only by the ANTs package). Due to the ITK 5.3.0 release, this PR replaces itk-unstable with 5.3.0 and makes it the default and renames 5.2.1 to itk_5_2. Even though only one package has so far switched to it out of the 5 or so packages depending on ITK directly, it seems to make 5.3.x the default in the interest of forward compatibility (VTK in Nixpkgs made the opposite decision and it's been annoying to get things updated, although perhaps not for technical reasons).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title itk: 5.2.1 -> 5.3.0 itk: unstable -> 5.3.0 Dec 20, 2022
@Mindavi
Copy link
Contributor

Mindavi commented Dec 25, 2022

@ofborg build c3d elastix simpleitk itk_5_2

@bcdarwin
Copy link
Member Author

@ofborg build ants

@Mindavi Mindavi merged commit 9c74821 into NixOS:master Dec 27, 2022
@bcdarwin bcdarwin deleted the update-itk branch December 27, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants