-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeipa: init at 4.10.1 #207115
freeipa: init at 4.10.1 #207115
Conversation
wow @SuperSandro2000 thanks for the amazingly in-depth review. I will address everything later today. |
I believe I have addressed all review comments at this point. |
This looks awesome! I'll try setting up some nodes with the new module after I get back to work (next week) |
Feel free to ping me on irc or matrix if you need help getting things working. It should just work but I’m available to help. |
@bjornfor I cleaned up all the commits. Please take another look. |
Can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the build failure ofborg discovered
@SuperSandro2000 what build failure? |
I don't know what build failure @SuperSandro2000 is referring to either. If we can't find it and there are no specific objections, perhaps we can actually merge this PR soon? |
I’d like that. |
Yay! Thanks! |
Oh hm, it's going into the staging branch - does that get merged to master automatically at some point? |
Yes... it just takes a few weeks I think |
Oh, I mistakenly assumed that the checks would display a red X for a failure. The grey square was too easy to overlook, sorry. |
Yeah, that is a known problem. I think freeipa is not building, so when this PR reaches master it will likely also not build. |
I'm taking a look to see if these are easy fixes. If not I suppose we'll want to temporarily revert. |
fwiw it appears that freeipa builds cleanly if you cherry-pick the commits from this PR onto the master branch. It's going to take a while for me to build staging to see the failure. |
The build failures I'm now seeing on the staging branch are things that I don't think could be caused by this PR:
|
I suspect this is going to be fine when it hits master. @SuperSandro2000 am I missing something glaringly obvious? |
Yes, gfortran will be certainly fixed before hitting master. |
Fails to eval in
Looks related? |
Ah, it's the result of alias use. Attempting to fix as #224026 |
o/ |
@Silver-Golden I have it working. You need to have a freeipa server set up. This PR only adds the client and a module for client configuration. You need to enroll once. The reason there isn't auto-enroll is becuase you need a password for an ipa account which is allowed to enroll users. If you want, I can share my freeipa-server and auto-enroll nix scripts. |
Please do, I would find an auto-enroll script useful too. You don't have freeipa-server running on nixos, do you? Because that would be very cool. |
I have freepia-server running in docker on nixos, with a declarative docker container. I will try to clean things up and post in the next couple of days. |
@benley: I've posted my configs for a freeipa-server (docker) and an ipa-tuura (https://github.com/freeipa/ipa-tuura) instance. The ipa-tuura instance is an ipa client (using the module in this PR), and also has an auto-enroll service (see systemd.services.init-sssd). Let me know what you think. https://gist.github.com/s1341/125b95ddc2edb4f7e174eca1ab217ca6 |
Description of changes
This PR allows nixos to be a fully-fledged freeipa (https://www.freeipa.org/page/Main_Page) client, by adding an
ipa
configuration module, and all required tools.This PR is a replacement for #22789, which updates all components and has been tested to work. I.e. I have tested that it is possible to login using credentials stored in the freeipa server. All credit goes to @outergod who did all the heavy lifting.
The configuration blob can be taken as is from the PR above.
Things still to do:
sssd
pam
configuration, which makes it impossible to change passwords. (I have a fix for this, but am unsure whether to include it in this PR).sssd
andfreeipa
sudo-rules. Need help from freeipa developers to debug and resolve.ipa
configuration module.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes