Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/meta.nix: make availableOn work when meta.platforms is missing #208687

Merged
merged 1 commit into from Jan 22, 2023
Merged

lib/meta.nix: make availableOn work when meta.platforms is missing #208687

merged 1 commit into from Jan 22, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 1, 2023

Description of changes

Currently, lib.meta.availableOn will fail for packages which omit meta.platforms (e.g. djbdns). This commit avoids that failure.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Currently, `lib.meta.availableOn` will fail for packages which omit
`meta.platforms` (e.g. `djbdns`).  This commit avoids that failure.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2023
@ghost ghost marked this pull request as ready for review January 2, 2023 00:22
@ghost ghost requested review from edolstra, nbp and infinisil as code owners January 2, 2023 00:22
@sternenseemann sternenseemann merged commit 0c9c29c into NixOS:master Jan 22, 2023
@ghost ghost deleted the pr/fix-meta-availableOn branch January 22, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant